-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anticipate TypeScript v5 changes #161
Conversation
Yep, this is generally good - we'll need to add the semver marker to the bases which changed and that'd be it 👍🏻 |
@orta it looks like two bases were modified, only one of which has an existing
|
Now that 5 is out, it's nice to revisit this and release a new version. |
@orta What are we going to do about this? Maintainers could edit this PR, or someone could open a new PR and just take over the work. |
I can modify things a bit more if needed, I'm not sure I understand what's been mentioned about versions, so if additional changes are needed I'll let you all guide me (or take over also obviously 👍) |
Sorry been out of the office for a while, yes - any affected .json file will need version field being added and bumped to v2 (or to the next version if it already exists) |
That sounds good! (I'm sorry I poked you so much. I hope your inbox isn't messed up 🤯) |
Sorry for taking so long for such a small change. I've added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks great to me
@acidoxee - never apologize for contributing to OSS at your own pace. The fact that you are doing something at all is very welcome!
I totally agree with @orta! Thank you so much to everyone who helped make this happen! ❤️ |
I really look forward to trying the new versions! |
Deploys happen overnight
…On Sat, Mar 25, 2023, at 7:12 PM, Alexander Kachkaev wrote:
I really look forward to trying the new versions! ***@***.***/strictest` still `1.0.2` as latest on npm ***@***.***/strictest?activeTab=versions>, which is six months old. What is left for getting v2 published?
—
Reply to this email directly, view it on GitHub <#161 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAL7DRYQLU5HEAWWCSMUEDW547SBANCNFSM6AAAAAAVVFNLBA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@orta seems like there was a problem with the deployment: https://github.com/tsconfig/bases/actions/runs/4522739115/jobs/7965413660 I've ran the script locally (just without the |
I've pushed 9f6f0fc which locks the deploy scripts stdlib and should probably fix the deploy |
It's now deployed successfully and available on npm. |
Should combined packages like |
Yep, done |
Closes #148
Closes #160