Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anticipate TypeScript v5 changes #161

Merged
merged 5 commits into from
Mar 25, 2023
Merged

Anticipate TypeScript v5 changes #161

merged 5 commits into from
Mar 25, 2023

Conversation

acidoxee
Copy link
Contributor

@acidoxee acidoxee commented Mar 9, 2023

Closes #148
Closes #160

@orta
Copy link
Member

orta commented Mar 9, 2023

Yep, this is generally good - we'll need to add the semver marker to the bases which changed and that'd be it 👍🏻

@BPScott
Copy link

BPScott commented Mar 16, 2023

@orta it looks like two bases were modified, only one of which has an existing _version marker. What would you want the new _version values to be in these cases? It seems like this version matches the version of what the config is for (i.e. in svelte's case it is for svelte v3.x,), however the change from importsNotUsedAsValues to verbatimModuleSyntax is a change that depends on the typescript version in use not the version of the library the config is for (i.e. before and after this change svelte.json would still work with svelte 3.x). How should the version change in this case?

  • svelte.json: Has an existing _version value of 3.0.0 (current published package version is 3.0.0)
  • strictest.json: Does not currently have a _version value (current published package veresion is 1.0.0)

@smorimoto
Copy link
Contributor

Now that 5 is out, it's nice to revisit this and release a new version.

@smorimoto
Copy link
Contributor

@orta What are we going to do about this? Maintainers could edit this PR, or someone could open a new PR and just take over the work.

@acidoxee
Copy link
Contributor Author

I can modify things a bit more if needed, I'm not sure I understand what's been mentioned about versions, so if additional changes are needed I'll let you all guide me (or take over also obviously 👍)

@smorimoto
Copy link
Contributor

@acidoxee Fantastic! It would be best that you complete this very nicely laid-out PR!
@orta I think all that remains is to provide the necessary guidance. Could you help us to merge this PR then make this package ready for TypeScript 5!

@orta
Copy link
Member

orta commented Mar 23, 2023

Sorry been out of the office for a while, yes - any affected .json file will need version field being added and bumped to v2 (or to the next version if it already exists)

@smorimoto
Copy link
Contributor

That sounds good! (I'm sorry I poked you so much. I hope your inbox isn't messed up 🤯)

@acidoxee
Copy link
Contributor Author

Sorry for taking so long for such a small change. I've added the _version field to the strictest config, and bumped both that one's and svelte's major versions. Is that what was expected?

Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks great to me

@acidoxee - never apologize for contributing to OSS at your own pace. The fact that you are doing something at all is very welcome!

@orta orta merged commit c48ea2c into tsconfig:main Mar 25, 2023
@smorimoto
Copy link
Contributor

I totally agree with @orta! Thank you so much to everyone who helped make this happen! ❤️

@kachkaev
Copy link

kachkaev commented Mar 25, 2023

I really look forward to trying the new versions! @tsconfig/strictest still 1.0.2 as latest on npm, which is six months old. What is left for getting v2 published?

@orta
Copy link
Member

orta commented Mar 25, 2023 via email

@acidoxee
Copy link
Contributor Author

@orta seems like there was a problem with the deployment: https://github.com/tsconfig/bases/actions/runs/4522739115/jobs/7965413660

I've ran the script locally (just without the npm publish step), and it properly detects svelte and strictest configs should be uploaded. I'm guessing there might have been some problem with the npm registry, or with the token maybe?

@orta
Copy link
Member

orta commented Mar 26, 2023

I've pushed 9f6f0fc which locks the deploy scripts stdlib and should probably fix the deploy

@smorimoto
Copy link
Contributor

It's now deployed successfully and available on npm.

@kachkaev
Copy link

Should combined packages like @tsconfig/node-lts-strictest-esm be marked as deprecated? They will no longer be updated and are also incompatible with TS5 because of "importsNotUsedAsValues": "error".

@orta
Copy link
Member

orta commented Mar 27, 2023

Yep, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants